Lp/vodafone 2 #1046

lucas-phillips28 · 2025-04-25T12:25:07Z

Change description

More tests

…dencies

hmcts-jenkins-cnp · 2025-04-25T12:37:03Z

Plan Result (stg)

⚠️ Resource Deletion will happen

This plan contains resource delete operation. Please check the plan result very carefully!

Plan: 0 to add, 5 to change, 1 to destroy.

Update
- module.apim_subscription_editvm[0].azurerm_api_management_subscription.subscription
- module.apim_subscription_portal[0].azurerm_api_management_subscription.subscription
- module.apim_subscription_powerplatform[0].azurerm_api_management_subscription.subscription
- module.apim_subscription_smoketest[0].azurerm_api_management_subscription.subscription
- module.pre-api-exception-alert[0].azurerm_resource_group_template_deployment.custom_alert[0]
Delete
- azurerm_api_management_api_diagnostic.api_mgmt_logs

Change Result (Click me)

  # azurerm_api_management_api_diagnostic.api_mgmt_logs will be destroyed
  # (because azurerm_api_management_api_diagnostic.api_mgmt_logs is not in configuration)
  - resource "azurerm_api_management_api_diagnostic" "api_mgmt_logs" {
      - always_log_errors         = true -> null
      - api_management_logger_id  = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/ss-stg-network-rg/providers/Microsoft.ApiManagement/service/sds-api-mgmt-stg/loggers/sds-api-mgmt-stg-logger" -> null
      - api_management_name       = "sds-api-mgmt-stg" -> null
      - api_name                  = "pre-api" -> null
      - http_correlation_protocol = "W3C" -> null
      - id                        = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/ss-stg-network-rg/providers/Microsoft.ApiManagement/service/sds-api-mgmt-stg/apis/pre-api/diagnostics/applicationinsights" -> null
      - identifier                = "applicationinsights" -> null
      - log_client_ip             = true -> null
      - operation_name_format     = "Name" -> null
      - resource_group_name       = "ss-stg-network-rg" -> null
      - sampling_percentage       = 100 -> null
      - verbosity                 = "verbose" -> null

      - backend_request {
          - body_bytes     = 8192 -> null
          - headers_to_log = [
              - "X-User-Id",
              - "accept",
              - "content-type",
              - "origin",
            ] -> null
        }

      - backend_response {
          - body_bytes     = 8192 -> null
          - headers_to_log = [
              - "accept",
              - "content-type",
              - "origin",
            ] -> null
        }

      - frontend_request {
          - body_bytes     = 8192 -> null
          - headers_to_log = [
              - "X-User-Id",
              - "accept",
              - "content-type",
              - "origin",
            ] -> null
        }

      - frontend_response {
          - body_bytes     = 8192 -> null
          - headers_to_log = [
              - "accept",
              - "content-type",
              - "origin",
            ] -> null
        }
    }

  # module.apim_subscription_editvm[0].azurerm_api_management_subscription.subscription will be updated in-place
  ~ resource "azurerm_api_management_subscription" "subscription" {
      ~ allow_tracing       = false -> true
        id                  = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/ss-stg-network-rg/providers/Microsoft.ApiManagement/service/sds-api-mgmt-stg/subscriptions/8265f455-2bf2-4c4b-8ba3-bfd0a2f5a6b7"
        # (10 unchanged attributes hidden)
    }

  # module.apim_subscription_portal[0].azurerm_api_management_subscription.subscription will be updated in-place
  ~ resource "azurerm_api_management_subscription" "subscription" {
      ~ allow_tracing       = false -> true
        id                  = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/ss-stg-network-rg/providers/Microsoft.ApiManagement/service/sds-api-mgmt-stg/subscriptions/500e642d-76ef-4d82-8741-bf9e9d979705"
        # (10 unchanged attributes hidden)
    }

  # module.apim_subscription_powerplatform[0].azurerm_api_management_subscription.subscription will be updated in-place
  ~ resource "azurerm_api_management_subscription" "subscription" {
      ~ allow_tracing       = false -> true
        id                  = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/ss-stg-network-rg/providers/Microsoft.ApiManagement/service/sds-api-mgmt-stg/subscriptions/37f73c17-345b-4c67-81d5-50d582e97227"
        # (10 unchanged attributes hidden)
    }

  # module.apim_subscription_smoketest[0].azurerm_api_management_subscription.subscription will be updated in-place
  ~ resource "azurerm_api_management_subscription" "subscription" {
      ~ allow_tracing       = false -> true
        id                  = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/ss-stg-network-rg/providers/Microsoft.ApiManagement/service/sds-api-mgmt-stg/subscriptions/da1d82f9-7187-4cb6-a6dd-b0020311f3bb"
        # (10 unchanged attributes hidden)
    }

  # module.pre-api-exception-alert[0].azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
  ~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
        id                       = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/pre-stg/providers/Microsoft.Resources/deployments/PRE_API_exception"
        name                     = "PRE_API_exception"
        tags                     = {}
      ~ template_content         = jsonencode(
          ~ {
              ~ parameters     = {
                  ~ actionGroupName          = {
                      ~ type = "String" -> "string"
                    }
                  ~ actionGroupRg            = {
                      ~ type = "String" -> "string"
                    }
                  ~ alertDesc                = {
                      ~ type = "String" -> "string"
                    }
                  ~ alertName                = {
                      ~ type = "String" -> "string"
                    }
                  ~ appInsightsName          = {
                      ~ type = "String" -> "string"
                    }
                  ~ appInsightsQuery         = {
                      ~ type = "String" -> "string"
                    }
                  ~ commonTags               = {
                      ~ type = "String" -> "string"
                    }
                  ~ customEmailSubject       = {
                      ~ type = "String" -> "string"
                    }
                  ~ frequencyInMinutes       = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ location                 = {
                      ~ type = "String" -> "string"
                    }
                  ~ severityLevel            = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ timeWindowInMinutes      = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ triggerThreshold         = {
                      ~ type = "String" -> "string"
                    }
                  ~ triggerThresholdOperator = {
                      ~ type          = "String" -> "string"
                        # (2 unchanged attributes hidden)
                    }
                }
                # (4 unchanged attributes hidden)
            }
        )
        # (6 unchanged attributes hidden)
    }

Plan: 0 to add, 5 to change, 1 to destroy.

hmcts-jenkins-cnp · 2025-04-25T12:37:36Z

Plan Result (prod)

⚠️ Resource Deletion will happen

This plan contains resource delete operation. Please check the plan result very carefully!

Plan: 0 to add, 2 to change, 1 to destroy.

Update
- module.pre-api-exception-alert[0].azurerm_resource_group_template_deployment.custom_alert[0]
- module.pre-api-liveness-alert[0].azurerm_resource_group_template_deployment.custom_alert[0]
Delete
- azurerm_api_management_api_diagnostic.api_mgmt_logs

Change Result (Click me)

  # azurerm_api_management_api_diagnostic.api_mgmt_logs will be destroyed
  # (because azurerm_api_management_api_diagnostic.api_mgmt_logs is not in configuration)
  - resource "azurerm_api_management_api_diagnostic" "api_mgmt_logs" {
      - always_log_errors         = true -> null
      - api_management_logger_id  = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/ss-prod-network-rg/providers/Microsoft.ApiManagement/service/sds-api-mgmt-prod/loggers/sds-api-mgmt-prod-logger" -> null
      - api_management_name       = "sds-api-mgmt-prod" -> null
      - api_name                  = "pre-api" -> null
      - http_correlation_protocol = "W3C" -> null
      - id                        = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/ss-prod-network-rg/providers/Microsoft.ApiManagement/service/sds-api-mgmt-prod/apis/pre-api/diagnostics/applicationinsights" -> null
      - identifier                = "applicationinsights" -> null
      - log_client_ip             = true -> null
      - operation_name_format     = "Name" -> null
      - resource_group_name       = "ss-prod-network-rg" -> null
      - sampling_percentage       = 100 -> null
      - verbosity                 = "verbose" -> null

      - backend_request {
          - body_bytes     = 8192 -> null
          - headers_to_log = [
              - "X-User-Id",
              - "accept",
              - "content-type",
              - "origin",
            ] -> null
        }

      - backend_response {
          - body_bytes     = 8192 -> null
          - headers_to_log = [
              - "accept",
              - "content-type",
              - "origin",
            ] -> null
        }

      - frontend_request {
          - body_bytes     = 8192 -> null
          - headers_to_log = [
              - "X-User-Id",
              - "accept",
              - "content-type",
              - "origin",
            ] -> null
        }

      - frontend_response {
          - body_bytes     = 8192 -> null
          - headers_to_log = [
              - "accept",
              - "content-type",
              - "origin",
            ] -> null
        }
    }

  # module.pre-api-exception-alert[0].azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
  ~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
        id                       = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Resources/deployments/PRE_API_exception"
        name                     = "PRE_API_exception"
        tags                     = {}
      ~ template_content         = jsonencode(
          ~ {
              ~ parameters     = {
                  ~ actionGroupName          = {
                      ~ type = "String" -> "string"
                    }
                  ~ actionGroupRg            = {
                      ~ type = "String" -> "string"
                    }
                  ~ alertDesc                = {
                      ~ type = "String" -> "string"
                    }
                  ~ alertName                = {
                      ~ type = "String" -> "string"
                    }
                  ~ appInsightsName          = {
                      ~ type = "String" -> "string"
                    }
                  ~ appInsightsQuery         = {
                      ~ type = "String" -> "string"
                    }
                  ~ commonTags               = {
                      ~ type = "String" -> "string"
                    }
                  ~ customEmailSubject       = {
                      ~ type = "String" -> "string"
                    }
                  ~ frequencyInMinutes       = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ location                 = {
                      ~ type = "String" -> "string"
                    }
                  ~ severityLevel            = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ timeWindowInMinutes      = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ triggerThreshold         = {
                      ~ type = "String" -> "string"
                    }
                  ~ triggerThresholdOperator = {
                      ~ type          = "String" -> "string"
                        # (2 unchanged attributes hidden)
                    }
                }
                # (4 unchanged attributes hidden)
            }
        )
        # (6 unchanged attributes hidden)
    }

  # module.pre-api-liveness-alert[0].azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
  ~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
        id                       = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Resources/deployments/PRE_API_liveness"
        name                     = "PRE_API_liveness"
        tags                     = {}
      ~ template_content         = jsonencode(
          ~ {
              ~ parameters     = {
                  ~ actionGroupName          = {
                      ~ type = "String" -> "string"
                    }
                  ~ actionGroupRg            = {
                      ~ type = "String" -> "string"
                    }
                  ~ alertDesc                = {
                      ~ type = "String" -> "string"
                    }
                  ~ alertName                = {
                      ~ type = "String" -> "string"
                    }
                  ~ appInsightsName          = {
                      ~ type = "String" -> "string"
                    }
                  ~ appInsightsQuery         = {
                      ~ type = "String" -> "string"
                    }
                  ~ commonTags               = {
                      ~ type = "String" -> "string"
                    }
                  ~ customEmailSubject       = {
                      ~ type = "String" -> "string"
                    }
                  ~ frequencyInMinutes       = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ location                 = {
                      ~ type = "String" -> "string"
                    }
                  ~ severityLevel            = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ timeWindowInMinutes      = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ triggerThreshold         = {
                      ~ type = "String" -> "string"
                    }
                  ~ triggerThresholdOperator = {
                      ~ type          = "String" -> "string"
                        # (2 unchanged attributes hidden)
                    }
                }
                # (4 unchanged attributes hidden)
            }
        )
        # (6 unchanged attributes hidden)
    }

Plan: 0 to add, 2 to change, 1 to destroy.

# Conflicts: # charts/pre-api/Chart.yaml # src/main/java/uk/gov/hmcts/reform/preapi/batch/application/processor/Processor.java

lucas-phillips28 and others added 14 commits April 15, 2025 12:58

fix: security issue for using e.printStackTrace()

bb9739e

chore: remove todo

b39881c

feat: add tests for RecordingUtils

0a07235

feat: add tests for MigratedItemGroup

5a66c24

feat: add tests for LoggingService

304e07d

feat: add tests for CSVReader

836efa4

chore: move tests to correct directory

0c06742

feat: add tests for ArchiveMetadataXmlExtractor

753bc76

feat: add tests for DeltaProcessor

c25a9f6

feat: add tests for RecordingMetadataProcessor

5948312

feat: add tests for BatchConfigration + add spring batch test depen…

ca9e166

…dencies

feat: add tests for ReferenceDataProcessor

21c9cee

feat: add tests for Processor

a8e0d3d

Bumping chart version/ fixing aliases

1ffd134

hmcts-jenkins-cnp bot added the stg/destroy label Apr 25, 2025

hmcts-jenkins-cnp bot added the prod/destroy label Apr 25, 2025

hmcts-jenkins-cnp bot deployed to preview April 25, 2025 12:37 View deployment

hmcts-jenkins-cnp bot added ns:pre prd:pre rel:pre-api-pr-1046 labels Apr 25, 2025

lucas-phillips28 added 2 commits April 28, 2025 09:08

Merge branch 'vodafone' into lp/vodafone-2

ae4cb52

# Conflicts: # charts/pre-api/Chart.yaml # src/main/java/uk/gov/hmcts/reform/preapi/batch/application/processor/Processor.java

chore: fix merge issues

8c5fc92

hmcts-jenkins-cnp bot deployed to preview April 28, 2025 08:27 View deployment

lucas-phillips28 marked this pull request as ready for review April 28, 2025 09:10

lucas-phillips28 requested a review from a team as a code owner April 28, 2025 09:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Lp/vodafone 2 #1046

Lp/vodafone 2 #1046

Uh oh!

lucas-phillips28 commented Apr 25, 2025 •

edited

Loading

Uh oh!

hmcts-jenkins-cnp bot commented Apr 25, 2025

Uh oh!

hmcts-jenkins-cnp bot commented Apr 25, 2025

Uh oh!

Uh oh!

Lp/vodafone 2 #1046

Are you sure you want to change the base?

Lp/vodafone 2 #1046

Uh oh!

Conversation

lucas-phillips28 commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change description

Uh oh!

hmcts-jenkins-cnp bot commented Apr 25, 2025

Plan Result (stg)

⚠️ Resource Deletion will happen

Uh oh!

hmcts-jenkins-cnp bot commented Apr 25, 2025

Plan Result (prod)

⚠️ Resource Deletion will happen

Uh oh!

Uh oh!

lucas-phillips28 commented Apr 25, 2025 •

edited

Loading