Create package.json in root & add prettier#32
Conversation
Signed-off-by: dav nguyxn <hoangson091104@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @hoangsonww, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes the foundational Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to create a root package.json and add prettier. However, the package.json file that was added is empty and not valid JSON. My review includes a critical comment with a suggestion to populate this file correctly to align with the PR's stated goal.
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
The package.json file is invalid as it only contains a newline character. A package.json file must contain valid JSON, starting with at least {}. Based on the PR title, it seems you intended to set up prettier at the root level. I've provided a suggestion to correctly structure this file with prettier as a dev dependency and a corresponding format script.
| { | |
| "name": "meadows-social-root", | |
| "private": true, | |
| "devDependencies": { | |
| "prettier": "^3.5.3" | |
| }, | |
| "scripts": { | |
| "format": "prettier --write \"**/*.{ts,tsx,js,jsx,json,css,scss,md,html}\"" | |
| } | |
| } |
There was a problem hiding this comment.
Pull request overview
Adds a root-level package.json, presumably to support repository-wide Node tooling (e.g., Prettier / lint-staged / Husky) alongside the existing web/ app setup.
Changes:
- Introduces
package.jsonat the repository root.
Comments suppressed due to low confidence (1)
package.json:2
package.jsonis currently empty/whitespace-only, which is invalid JSON and will causenpmtooling (and anynpx lint-staged/Husky hooks expecting root scripts) to fail. Please replace it with a validpackage.jsonthat includes at leastname,private, and the intendedscripts/devDependencies(e.g.,prettier,lint-staged,huskyor wiring to the existingweb/scripts).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Please include a summary of the changes and the related issue. Also include any relevant motivation and context.
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist