Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 358 - Support for JDK 17 #382

Merged
merged 10 commits into from
Sep 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 33 additions & 13 deletions .github/workflows/github-actions-basic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,25 +16,45 @@ jobs:
strategy:
fail-fast: false
matrix:
spark:
- 2.4.8
- 3.0.2
- 3.1.2
- 3.2.2
- 3.3.1
- 3.4.0
- 3.4.1
- 3.5.0
include:
- spark: "2.4.8"
java-version: "11"
distribution: "temurin"
- spark: "3.0.2"
java-version: "11"
distribution: "temurin"
- spark: "3.1.2"
java-version: "11"
distribution: "temurin"
- spark: "3.2.2"
java-version: "11"
distribution: "temurin"
- spark: "3.3.1"
java-version: "11"
distribution: "temurin"
- spark: "3.4.0"
java-version: "11"
distribution: "temurin"
- spark: "3.4.0"
java-version: "17"
distribution: "temurin"
# - spark: "4.0.0-PREVIEW2"
# java-version: "17"
# distribution: "temurin"
env:
SPARK_VERSION: ${{ matrix.spark }}
steps:
- name: Checkout spark-testing-base
uses: actions/[email protected]
# In order to fetch changed files
# with:
# fetch-depth: 0
# repository: holdenk/spark-testing-base
# ref: main
with:
fetch-depth: 0
repository: holdenk/spark-testing-base
ref: main
- uses: actions/setup-java@v3
with:
java-version: ${{ matrix.java-version }}
distribution: ${{ matrix.distribution }}
- name: Cache maven modules
id: cache-maven
uses: actions/[email protected]
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ While we hope you choose our library, https://github.com/juanrh/sscheck , https:

## [Release Notes](RELEASE_NOTES.md)

JDK17 support exists only for Spark 3.4.0

## Security Disclosure e-mails

Have you found a security concern? Please let us know
Expand Down
3 changes: 3 additions & 0 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,8 @@ def excludeJavaxServlet(items: Seq[ModuleID]) =
def excludeJpountz(items: Seq[ModuleID]) =
excludeFromAll(items, "net.jpountz.lz4", "lz4")



lazy val kafkaPublishSettings =
publishSettings ++ Seq(
skip in publish := scalaVersion.value >= "2.12.0"
Expand Down Expand Up @@ -243,3 +245,4 @@ lazy val publishSettings = Seq(

lazy val noPublishSettings =
skip in publish := true
}
Loading