Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [~] row comparer & add list aprox comparer #415

Merged
merged 2 commits into from
May 4, 2024

Conversation

eruizalo
Copy link
Contributor

There is one major error when comparing with structs after 2f6259c in which if the first struct is ok the rest of the test does not evaluate

New feature adding tolerance to collections

Copy link
Contributor

@rafafrdz rafafrdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question, could the boolean expression be improved?

@holdenk holdenk merged commit d5bfe78 into holdenk:main May 4, 2024
8 checks passed
@eruizalo eruizalo deleted the fix/row_comparer branch May 5, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants