-
Notifications
You must be signed in to change notification settings - Fork 0
Add utility to convert XAUUSD time column format #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
holguinmora123
wants to merge
1
commit into
main
Choose a base branch
from
codex/modify-time-format-in-xauusd_data_10min.csv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # OpenAi_Codex | ||
|
|
||
| This repository now includes a small utility script to normalise the `time` column in CSV files. The script removes timezone information (e.g. `+00:00`) so the format matches entries like `2025-09-09 06:29:00` from `XAUUSD_data.csv`. | ||
|
|
||
| ## Usage | ||
|
|
||
| ``` | ||
| python convert_time_format.py XAUUSD_data_10min.csv | ||
| ``` | ||
|
|
||
| The command overwrites the input file with the `time` column formatted as `YYYY-MM-DD HH:MM:SS`. Use the `-o` option to write to a different file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import pandas as pd | ||
| from pathlib import Path | ||
|
|
||
| def convert_time_format(input_file: str, output_file: str | None = None) -> Path: | ||
| """Convert the `time` column of a CSV to 'YYYY-MM-DD HH:MM:SS'. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| input_file: str | ||
| Path to the CSV file whose `time` column may contain timezone info. | ||
| output_file: str | None, optional | ||
| Path to save the converted CSV. If omitted, the input file is overwritten. | ||
|
|
||
| Returns | ||
| ------- | ||
| Path | ||
| Path to the written CSV file. | ||
| """ | ||
| df = pd.read_csv(input_file) | ||
| if 'time' not in df.columns: | ||
| raise ValueError("CSV must contain a 'time' column") | ||
|
|
||
| # Parse dates and drop timezone info if present, then format like 'YYYY-MM-DD HH:MM:SS' | ||
| times = pd.to_datetime(df['time']) | ||
| times = times.dt.tz_localize(None) # Remove timezone if it exists | ||
| df['time'] = times.dt.strftime('%Y-%m-%d %H:%M:%S') | ||
|
|
||
| output_path = Path(output_file) if output_file else Path(input_file) | ||
| df.to_csv(output_path, index=False) | ||
| return output_path | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| import argparse | ||
|
|
||
| parser = argparse.ArgumentParser(description="Normalize the time column format in a CSV") | ||
| parser.add_argument("input_file", help="CSV file with a time column") | ||
| parser.add_argument("-o", "--output-file", help="Where to save the converted CSV", default=None) | ||
| args = parser.parse_args() | ||
|
|
||
| out_path = convert_time_format(args.input_file, args.output_file) | ||
| print(f"Converted CSV written to {out_path}") | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Guard tz-localization for timezone-naive inputs
The conversion unconditionally applies
times.dt.tz_localize(None). Pandas raisesTypeError: Already tz-naive, use tz_localize to localizewhen the series has no timezone information, so the tool fails for CSVs that are already in the desiredYYYY-MM-DD HH:MM:SSformat. Handling naive timestamps (e.g. by usingtz_convert(None)or wrapping the call in a try/except) would let the script safely normalize both timezone-aware and timezone-free files.Useful? React with 👍 / 👎.