PR Add Windows Pathing Compatibility#6
Merged
fredoliveira merged 3 commits intoholonoms:mainfrom Jun 19, 2025
Merged
Conversation
- Normalize paths using filepath.ToSlash() in processor for cross-platform gitignore matching - Add defensive path normalization to filetree package using strings.FieldsFunc - Add comprehensive tests for mixed path separators and edge cases
fredoliveira
requested changes
Jun 19, 2025
Member
There was a problem hiding this comment.
Hey Taylor! Thanks for submitting this!
I tested this locally and found one small issue - the filepath.ToSlash() approach doesn't handle literal backslashes on Unix systems. I believe this will work across both Windows and unix-based systems:
// In filetree.go, replace the normalization logic with:
parts := strings.FieldsFunc(path, func(r rune) bool {
return r == '/' || r == '\\'
})This handles both separators directly without string replacement and removes the need for the filepath import (you can remove that too). All tests should pass with this change :)
Contributor
Author
|
Updated and it looks like it's working! |
Merged
fredoliveira
approved these changes
Jun 19, 2025
Member
fredoliveira
left a comment
There was a problem hiding this comment.
@TWDickson looks great! Thank you for updating the code. Merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows compatibility failed due to hardcoded unix path separators in file tree generation and gitignore pattern matching. I have not tested on a Unix based system.