This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to address #8
What I've written so far isn't quite true; we don't currently have
autover.get_setup_version()
. But we should probably first agree on what the docs ought to say before changing anything.I think the advantage of recommending to embed and having
get_setup_version()
in autover itself is that there is only one file to worry about (version.py), rather than having to copy/paste functions into setup.py files. Also, there's no need to worry about having to download a file (something that has caused me confusion multiple times...).(I've probably mixed up version.py and autover.py; not sure if we're going to do #25.)