-
Notifications
You must be signed in to change notification settings - Fork 0
Attempting to load from file first #66
base: main
Are you sure you want to change the base?
Conversation
To my great surprise the tests have passed. I can't think through the consequences of this change other than to state the obvious:
|
Currently the For this PR to work we want:
Options for generating the
|
e9e09f5
to
645d40a
Compare
I'm happy with either option, favoring option 1 if we can make the generated .version file be deleted automatically after creating the package. If it's not practical to ensure that the .version file gets cleaned up, I'd favor option 2 so that the file is generated explicitly and then deleted explicitly; automatically generating it without automatically deleting it seems like it will lead to many problems with stale .version files. |
Just in case a simple change actually works (very unlikely).