-
-
Notifications
You must be signed in to change notification settings - Fork 567
Fixes for OAuth via proxy #8211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8211 +/- ##
==========================================
- Coverage 86.01% 85.90% -0.12%
==========================================
Files 348 348
Lines 53985 53986 +1
==========================================
- Hits 46435 46376 -59
- Misses 7550 7610 +60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
So the test passes, which based on my own real-world tests just means that the test is flawed. It would be great if someone could reproduce the issue independently though. NB: The test failure is unrelated. |
|
It would be good to figure out in what way the test is flawed. My suspicion is that the test correctly configures the proxy in a way that's a) not documented and b) isn't the case in your setup. What I suspect is making it work is this: which strips the |
|
Indeed with this reverse proxy config, the issue cannot occur since the application is accessed at a path that corresponds to the application name (/proxy/app_name rewritten as /app_name). The configuration could be modified to make the test more general. I will experiment and come up with a configuration proposal against which basic auth and OAuth modules should be tested. Edit: it may not be straightforward, because ideally, the reverse proxy rule should know of the application name, whereas currently it is set up before it could be known based on the temporary file name. |
The goal is to address issues mentioned in #3555
For starters, I believe the
test_auth0_oauth_via_proxytest function does not actually test the proxy mechanism because the page is accessed via the wrong port, bypassing the reverse proxy.Let's see if the test still passes (I don't want to create an Auth0 account to get a key so I can't check it locally).