Skip to content

Conversation

@maximlt
Copy link
Member

@maximlt maximlt commented Oct 30, 2025

As done in other HoloViz repos, as we found out the best way for contributors to get started is to have a single command (pixi run setup-dev) to get started, and to have a single default environment with pretty much everything they need to contribute (test deps, ui deps, docs deps, etc.), environment in which panel is already installed in editable mode and that has pre-commit already set up.

@maximlt maximlt marked this pull request as draft October 30, 2025 15:40
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.00%. Comparing base (a404cfd) to head (62f6512).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8277      +/-   ##
==========================================
- Coverage   86.00%   86.00%   -0.01%     
==========================================
  Files         348      348              
  Lines       54378    54378              
==========================================
- Hits        46770    46767       -3     
- Misses       7608     7611       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maximlt
Copy link
Member Author

maximlt commented Oct 31, 2025

I ran the full test CI and the jobs all passed (https://github.com/holoviz/panel/actions/runs/18968966032):

image

@maximlt maximlt marked this pull request as ready for review October 31, 2025 11:00
@maximlt maximlt requested a review from hoxbro October 31, 2025 11:01
Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments otherwise LGTM

@@ -1,4 +1,4 @@
[project]
[workspace]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add something like this https://github.com/holoviz/holoviews/pull/6699/files to the documentation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 8941b6a

I don't know about you, but I'm getting a little tired about updating the developer docs the same way in every repo 🙃

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine this was how pyctdev started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants