-
-
Notifications
You must be signed in to change notification settings - Fork 567
Enhance developer experience with the setup-dev command #8277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8277 +/- ##
==========================================
- Coverage 86.00% 86.00% -0.01%
==========================================
Files 348 348
Lines 54378 54378
==========================================
- Hits 46770 46767 -3
- Misses 7608 7611 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I ran the full test CI and the jobs all passed (https://github.com/holoviz/panel/actions/runs/18968966032):
|
hoxbro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments otherwise LGTM
| @@ -1,4 +1,4 @@ | |||
| [project] | |||
| [workspace] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add something like this https://github.com/holoviz/holoviews/pull/6699/files to the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 8941b6a
I don't know about you, but I'm getting a little tired about updating the developer docs the same way in every repo 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine this was how pyctdev started.
Co-authored-by: Simon Høxbro Hansen <[email protected]>

As done in other HoloViz repos, as we found out the best way for contributors to get started is to have a single command (
pixi run setup-dev) to get started, and to have a singledefaultenvironment with pretty much everything they need to contribute (test deps, ui deps, docs deps, etc.), environment in which panel is already installed in editable mode and that has pre-commit already set up.