Skip to content

revert: add restriction callback to restrict visibility and modification of widget kinds" #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

Meierschlumpf
Copy link
Member

Reverts #2658
The reason is that with next 15.2+ there can not be any dependency loops. And with the two usages of widgetImports in old-import and api package this would be the case api -> widget -> api.

See https://discord.com/channels/972958686051962910/973659470183956610/1355490224729231390 for further details

Error from nextjs:

@homarr/nextjs:dev: FATAL: An unexpected Turbopack error occurred. Please report the content of C:\Users\meier\AppData\Local\Temp\next-panic-12b7ebb83ff1914cfaa80142b275ce1c.log, along with a description of what you were doing when the error occurred, to https://github.com/vercel/next.js/issues/new?template=1.bug_report.yml

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Mar 29, 2025
@Meierschlumpf Meierschlumpf self-assigned this Mar 29, 2025
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner March 29, 2025 11:35
Copy link

deepsource-io bot commented Mar 29, 2025

Here's the code health analysis summary for commits d1b14ac..e5f53ce. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
🎯 1 occurence resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.18% 10040 / 45260
🔵 Statements 22.18% 10040 / 45260
🔵 Functions 29.9% 427 / 1428
🔵 Branches 63.72% 1235 / 1938
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/nextjs/src/components/board/items/item-content.tsx 0% 0% 0% 0% 1-120
apps/nextjs/src/components/board/items/item-menu.tsx 0% 0% 0% 0% 1-126
apps/nextjs/src/components/board/items/item-select-modal.tsx 0% 0% 0% 0% 1-107
packages/api/src/router/board.ts 59.84% 80.85% 82.35% 59.84% 52-60, 63-70, 76-101, 177-246, 296-507, 526-530, 543-545, 548-550, 558, 748-944, 966-986, 1102-1117, 1206, 1225, 1236-1251, 1256-1257, 1279-1294, 1299-1300, 1319-1321, 1346-1348, 1439-1440, 1464-1465, 1569-1573, 1630-1631, 1639-1640
packages/api/src/router/import/import-router.ts 71.87% 100% 100% 71.87% 18, 29-34, 40-41
packages/auth/permissions/index.ts 100% 100% 100% 100%
packages/old-import/src/index.ts 25% 100% 0% 25% 8-13
packages/old-import/src/import/import-initial-oldmarr.ts 5.55% 100% 0% 5.55% 17-56
packages/old-import/src/import/import-single-oldmarr.ts 6.66% 100% 0% 6.66% 12-42
packages/old-import/src/import/collections/board-collection.ts 15.45% 88.88% 50% 15.45% 19-128
packages/widgets/src/definition.ts 100% 100% 100% 100%
Generated in workflow #5744 for commit e5f53ce by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf merged commit 63f66c0 into dev Mar 29, 2025
13 checks passed
Meierschlumpf added a commit that referenced this pull request Mar 29, 2025
@Meierschlumpf Meierschlumpf deleted the revert-2658-widget-restriction branch March 29, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant