-
-
Notifications
You must be signed in to change notification settings - Fork 101
fix: Recalculate time ago on re-render #4107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Recalculate time ago on re-render #4107
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for this fix
I'll take a quick look in about 20 minutes so we can put it into todays release |
Tried it out locally with 5 second update interval and worked like a charm (a few seconds ago was updated to one minute ago etc.) |
Thanks for getting to this so quickly! Looking forward to using the officially deployed image again 😎. |
Homarr
Checklist
Thank you for your contribution. Please ensure that your pull request meets the following pull request:
pnpm build
, autofix withpnpm format:fix
)dev
branchx
,y
,i
or any abbrevation)Description
Fixes:
When you set an aggressive enough Notification Updater frequency, your notification timestamps get stuck in their initial state. The parent
<NotificationsWidget />
component subscribes to notification updates, so it will necessarily re-render at least as frequently as your Notification Updater configuration. This means theuseTimeAgo
hook will always clear the update interval before it performs the update in these scenarios.Closes #4091