Skip to content

Conversation

castielwaverly
Copy link
Contributor

@castielwaverly castielwaverly commented Sep 19, 2025


Homarr

Checklist

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm build, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)
  • Documentation is up to date. Create a pull request here.

Description

Fixes:

When you set an aggressive enough Notification Updater frequency, your notification timestamps get stuck in their initial state. The parent <NotificationsWidget /> component subscribes to notification updates, so it will necessarily re-render at least as frequently as your Notification Updater configuration. This means the useTimeAgo hook will always clear the update interval before it performs the update in these scenarios.

Closes #4091

Copy link
Contributor

deepsource-io bot commented Sep 19, 2025

Here's the code health analysis summary for commits 0a908de..4b7b44a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@castielwaverly castielwaverly marked this pull request as ready for review September 19, 2025 16:27
@castielwaverly castielwaverly requested a review from a team as a code owner September 19, 2025 16:27
@manuel-rw manuel-rw added bug Something isn't working confirmed Confirmation that the bug actually exists labels Sep 26, 2025
Copy link
Member

@manuel-rw manuel-rw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for this fix

@Meierschlumpf
Copy link
Member

I'll take a quick look in about 20 minutes so we can put it into todays release

@Meierschlumpf
Copy link
Member

Tried it out locally with 5 second update interval and worked like a charm (a few seconds ago was updated to one minute ago etc.)

@Meierschlumpf Meierschlumpf merged commit 0b15561 into homarr-labs:dev Sep 26, 2025
11 of 12 checks passed
@castielwaverly
Copy link
Contributor Author

Thanks for getting to this so quickly! Looking forward to using the officially deployed image again 😎.

@castielwaverly castielwaverly deleted the fix/4091-recalculate-time-ago branch September 26, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed Confirmation that the bug actually exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Notification "time ago" timestamps not updating
3 participants