Skip to content

Conversation

@mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Oct 10, 2025

Remove support for deprecated supervisor options: wait-boot and repositories. These will be dropped in home-assistant/supervisor#6226

Summary by CodeRabbit

  • Refactor

    • Removed deprecated CLI flags for supervisor options: wait-boot and repositories are no longer supported.
    • Eliminated associated handling and completions for these flags in the CLI.
  • Documentation

    • Updated core options usage examples to reflect current flags, replacing wait_boot with backups-exclude-database.
    • Refreshed help text to align with the removal of unsupported flags.

@coderabbitai
Copy link

coderabbitai bot commented Oct 10, 2025

📝 Walkthrough

Walkthrough

The pull request updates example text in cmd/core_options.go and removes wait-boot and repositories flags, their parsing, option population, and completions from cmd/supervisor_options.go.

Changes

Cohort / File(s) Summary
Core options example text update
cmd/core_options.go
Adjusted example usage text from --wait_boot 600 to --backups-exclude-database=true; no logic changes.
Supervisor CLI flag removal
cmd/supervisor_options.go
Removed wait-boot (int) and repositories (string array) flags, their completion hooks, retrieval via GetInt/GetStringArray, debug logs, and population of options["wait_boot"] and options["addons_repositories"].

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant U as User
  participant CLI as ha supervisor (cmd)
  participant FP as Flag Parser
  participant OB as OptionsBuilder
  participant API as Supervisor API

  U->>CLI: Run command with flags
  CLI->>FP: Parse flags
  Note over FP,CLI: Removed flags: wait-boot, repositories
  FP-->>CLI: Parsed args (without removed flags)

  CLI->>OB: Build options map
  OB-->>CLI: options (no wait_boot / addons_repositories)
  CLI->>API: Send request with options
  API-->>CLI: Response
  CLI-->>U: Output
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title accurately and succinctly conveys the primary change of removing deprecated options, matching the core modifications in the diff without introducing ambiguity or unrelated content.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-deprecated-fields

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 052a356 and b8d70e2.

📒 Files selected for processing (2)
  • cmd/core_options.go (1 hunks)
  • cmd/supervisor_options.go (0 hunks)
💤 Files with no reviewable changes (1)
  • cmd/supervisor_options.go
🧰 Additional context used
📓 Path-based instructions (1)
*/**(html|markdown|md)

⚙️ CodeRabbit configuration file

*/**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.

  • Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
  • In step-by-step instructions, front the location phrase in the instructional sentence.
  • In step-by-step instructions, front the 'goal' in the instructional sentence.
  • In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
  • do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'

*/**(html|markdown|md): - Use bold to mark UI strings.

  • If "" are used to mark UI strings, replace them by bold.

  • Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"

  • Use sentence-style capitalization also in headings.

do not comment on HTML used for icons

Avoid flagging inline HTML for embedding videos in future reviews for this repository.

Files:

  • cmd/core_options.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@agners agners merged commit 74c9ce8 into master Oct 13, 2025
9 checks passed
@agners agners deleted the remove-deprecated-fields branch October 13, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants