-
-
Couldn't load subscription status.
- Fork 1.2k
Clarify API endpoint path requirement #2848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Added note about trailing slash in API endpoint. This tripped me up because I didn't expect it (many/most other API's I've used don't include a trailing `/` in paths)
📝 WalkthroughWalkthroughAdded a clarifying note to the REST API documentation specifying that the API path must include a trailing slash (full path: /api/, not /api) in the sample curl command under the /api/ ApiEndpoint section. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/api/rest.md (1)
82-83: Consider using the structured callout syntax for consistency.The documentation uses
:::note,:::info, and:::tipblocks elsewhere (e.g., lines 585, 694, 739). Refactoring this note to use:::notewould maintain visual consistency:-Note: make sure you include the trailing `/`, the full path is `/api/`, NOT `/api` +:::note +Make sure you include the trailing `/`. The full path is `/api/`, NOT `/api`. +:::This is optional but would align with the established documentation style.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
docs/api/rest.md(1 hunks)
🔇 Additional comments (1)
docs/api/rest.md (1)
82-83: Helpful clarification!The note effectively addresses the trailing slash requirement for the
/api/endpoint. The placement after the sample curl command (which correctly demonstrates the full path) makes it visible to users referencing this documentation.
Proposed change
Added note about trailing slash in API endpoint. This tripped me up because I didn't expect it (many/most other API's I've used don't include a trailing
/in paths). I hope that by including this note it will help someone else who is getting started with the API for the first time (since this is likely the API endpoint that they will try first)Type of change
Checklist
Additional information
Summary by CodeRabbit