Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration Complete: MobX → Legend-State v3
Results: 167/167 tests passing, build clean, zero MobX references remaining.
What changed
Production code (7 files):
Key architectural decisions:
Tests (6 files):
Known limitation
The observer HOC from @legendapp/state/react causes infinite re-render loops when used with useFormState (the form state hook modifies observables in useEffect that observer tracks). The FormStateApp demo component works without observer because useFormState already handles re-rendering. This needs investigation — likely a Legend-State v3 beta interaction with React's effect lifecycle.