-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add summary spans depending on the rule -- EXPERIMENTAL #1508
base: main
Are you sure you want to change the base?
Conversation
85c74e3
to
f8ae757
Compare
Fields I've added and what they actually mean:
And then it also includes the other meta.things like The consequences of basing it on an existing spanBy using either the root span or "the first span" as the basis for the summary, it ends up having some values like telemetry.sdk.name, span.kind, library.name, and others that simply incorrect. The benefit is that stuff like status_code, error, and http.url show up. What to change?From a Jobs-to-be-Done perspective, I want the summary span to be able to:
The summary will then be quite different if we received a root span or not.
I'm going to focus on making the "root arrived + dropped trace" use case the best available since it is what is easiest to start with. Suggest a follow-up effort to build a recurring summary follow-up that would require a separate buffer to hold onto some summary data that can be used to capture follow-on spans after the decision is made. |
Which problem is this PR solving?
When sending data through Refinery, maybe it'd be nice to have a summary of each trace.
Short description of the changes
This adds a new span that goes to a separate "Span Summary" dataset where you can see a single span for each trace that hits refinery and whatever refinery thought about it when it was being evaluated.
EXPERIMENTAL
It has a lot of janky stuff right now that needs validation so it's a draft until we play with it with some realistic data and see what the summaries look like.