Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): update to vitest 3 #3861

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Conversation

yasuaki640
Copy link
Contributor

Updated to vitest 3.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.24%. Comparing base (65edaf2) to head (1430198).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3861      +/-   ##
==========================================
+ Coverage   90.78%   91.24%   +0.46%     
==========================================
  Files         162      162              
  Lines       10263    10280      +17     
  Branches     2893     2897       +4     
==========================================
+ Hits         9317     9380      +63     
+ Misses        945      899      -46     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe
Copy link
Member

Hi @yasuaki640

Thank you for the PR. Updating Vitest to v3 is good!

I tried it, but I can see some warnings like this:

CleanShot 2025-01-27 at 22 59 24@2x

I think it will be better to add fixes to remove warnings in this PR. What do you think of it?

@yusukebe
Copy link
Member

yusukebe commented Feb 5, 2025

Hey @yasuaki640

I tweaked. It looks good! Thank you!

@yusukebe yusukebe merged commit 066c342 into honojs:main Feb 5, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants