Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: perf(types): replace to interface #3886

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EdamAme-x
Copy link
Contributor

@EdamAme-x EdamAme-x commented Feb 3, 2025

This is an experiment.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (65edaf2) to head (7c22e42).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3886    +/-   ##
========================================
  Coverage   90.78%   90.78%            
========================================
  Files         162      162            
  Lines       10263    10263            
  Branches     2893     3010   +117     
========================================
  Hits         9317     9317            
  Misses        945      945            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdamAme-x
Copy link
Contributor Author

EdamAme-x commented Feb 3, 2025

Then, one thing I have noticed.

It appears that PRs other than @yusukebe's do not show this.
#3885 (comment)

@EdamAme-x EdamAme-x marked this pull request as draft February 3, 2025 12:34
@EdamAme-x EdamAme-x changed the title wip: perf types wip: perf(types): replace to interface Feb 3, 2025
@yusukebe
Copy link
Member

yusukebe commented Feb 4, 2025

@EdamAme-x

I've tried the same things that convert type to interface before. But the performance did not change at that time.

It appears that PRs other than @yusukebe's do not show this.

Maybe it's a security issue. We have to investigate it.

@EdamAme-x
Copy link
Contributor Author

Thanks.
I will think another approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants