build(deps): Update package.json so @hono/vite-dev-server has a ^ semver range allowing 0.18.1#254
Open
gobengo wants to merge 2 commits intohonojs:mainfrom
Open
build(deps): Update package.json so @hono/vite-dev-server has a ^ semver range allowing 0.18.1#254gobengo wants to merge 2 commits intohonojs:mainfrom
gobengo wants to merge 2 commits intohonojs:mainfrom
Conversation
gobengo
commented
Jan 16, 2025
yusukebe
changed the title
yusukebe
changed the title
yusukebe
reviewed
Jan 18, 2025
| "@babel/traverse": "7.25.6", | ||
| "@babel/types": "7.25.6", | ||
| "@hono/vite-dev-server": "0.18.0", | ||
| "@hono/vite-dev-server": "^0.18.1", |
Member
There was a problem hiding this comment.
I fixed the version intentionally without ^ to prevent unexpected behavior (I know it's a rare case) when the user installs the version not specified. So, it should be 0.18.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…owing 0.18.1