Support changes made when multiple fields rules match the target #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case where multiple "fields" have been registered (e.g. logic attached to "input[min]" fields and a separate rule attached to "input[max]" fields), allow the validation to apply to targets that have been changed that match both rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where multiple "fields" have been registered that may overlap, allow the validation logic to apply to targets that have been changed that match multiple rules (e.g. if addField('input[min]', ...) was registered separate from addField('input[max]', ...), but a form input potentially supports both)
I appreciate this may be slightly outside the intent of
addFieldas I'm treating it conceptually a bit more like anaddRuleto a particular "category of fields", but it helped my use case when attempting to have lots of small pieces of generic reusable rules rather than handcrafting for a particular form quite so specifically.