-
Notifications
You must be signed in to change notification settings - Fork 13
Fix Type Error in shoutConnected Function #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
heydarideveloper
wants to merge
18
commits into
hosseinmd:main
Choose a base branch
from
heydarideveloper:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not type error, in the previse version of socket.io before of connection be done we had |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request addresses a TypeScript error encountered when calling the shoutConnected(connection.id) function in the react-signalr package. The error occurs because connection.id can be undefined, while the function expects a parameter of type string | null.
Changes Made
Updated the function call to ensure it only passes a valid string or null value.
Implemented the following modification:
Benefits
This change prevents TypeScript errors and enhances type safety, ensuring that users of the package do not encounter similar issues when connection.id is undefined.
Testing
Verified that the updated code compiles without any TypeScript errors.
Ensured that the functionality remains intact after the change.
Thank you for considering this fix! I look forward to your feedback. Feel free to adjust any part of this text as needed before submitting your pull request!