Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Améliorations d'accessibilité sur le formulaire d'inscription #769

Closed
wants to merge 1 commit into from
Closed

Améliorations d'accessibilité sur le formulaire d'inscription #769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions app/views/users/_form.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
<div class="bg-white p-3 py-4 p-lg-4 rounded">
<%= simple_form_for @user do |f| %>
<div class="bg-white p-3 py-4 p-lg-4 rounded">

<% if @user.present? && @user.errors.any? %>
<div class="alert alert-danger" role="alert" style="position: inherit">
<% @user.errors.full_messages.each do |msg| %>
<%= msg %><br/>
<% end %>
</div>
<% end %>
<% if @user.present? && @user.errors.any? %>
<div class="alert alert-danger" role="alert" style="position: inherit">
<% @user.errors.full_messages.each do |msg| %>
<%= msg %><br/>
<% end %>
Comment on lines +6 to +8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour améliorer l'accessibilité on va également éviter les <br /> 🙂

Suggested change
<% @user.errors.full_messages.each do |msg| %>
<%= msg %><br/>
<% end %>
<ul>
<% @user.errors.full_messages.each do |msg| %>
<li><%= msg %></li>
<% end %>
</ul>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci @EmCousin ! C'est mieux effectivement, je te propose de garder ça pour une PR séparée :

  • pour le faire sur toutes les pages qui contiennent des alertes de ce type
  • et éventuellement affiner un peu pour éviter de faire une ul s'il n'y a qu'un seul message à afficher

En l'état je n'ai fait que reprendre l'existant (ça n'apparait dans le diff qu'à cause des indentations qui ont changé)

</div>
<% end %>

<%= simple_form_for @user do |f| %>
<%= f.input :email,
label: false,
label: "Adresse email",
error: f.error(:email),
placeholder: "[email protected]",
hint: "Une adresse email ne peut être utilisée que par une seule personne.",
Expand All @@ -20,25 +20,25 @@
<hr>

<%= f.input :address,
label: false,
label: "Adresse",
error: f.error(:address),
placeholder: "Adresse",
placeholder: "5 avenue de Paris",
required: true,
input_html: {class: "pr-5"} %>

<%= f.input_field :lat, as: :hidden %>
<%= f.input_field :lon, as: :hidden %>

<%= f.input :phone_number,
label: false,
label: "Numéro de téléphone portable",
error: "Numéro de téléphone invalide",
placeholder: "Numéro de téléphone portable",
placeholder: "06 00 00 00 00",
required: true,
input_html: {autocomplete: "tel"} %>

<%= f.input :birthdate,
as: :date,
label: false,
label: "Date de naissance",
order: [:day, :month, :year],
start_year: Date.today.year - 120,
end_year: Date.today.year - 18,
Expand All @@ -54,9 +54,9 @@

<%= f.invisible_captcha :subtitle %>
<%= f.button :submit, "S’inscrire", class: "btn btn-secondary btn-lg btn-block font-weight-bold", data: {disable_with: "Inscription en cours..."} %>
<% end %>

</div>
<div class="py-1 px-2">
<%= render partial: "users/mentions" %>
</div>
</div>
<div class="py-1 px-2">
<%= render partial: "users/mentions" %>
</div>
<% end %>