-
-
Notifications
You must be signed in to change notification settings - Fork 10
Prepare for 0.016 release #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2d08324
to
65b122b
Compare
Update MANIFEST; include README.md in MANIFEST.
Bump version to 0.015_002
Log status of hashref returned by WriteMakefile(). (Redirect STDERR to file on disk.)
Having converted to a Makefile.PL similar to that of Type-Tiny. Whitespace cleanup.
Attempt to add 'recommends' NOT SUCCEEDING!
Encapsulate code into handle_conflicts(). When envvar PERL_AUTHOR_TESTING is set, test xt/*.t as well.
Calling that sub had no effect on Makefile or MYMETA.json. Test-Vars is apparently not complex enough to create conflicts with its revdeps.
Per investigation of Changes for EU::MM 6.57_02. The more modern version takes an array ref of authors; the older version only took a string.
This test will presume that the MYMETA files have been created, which is performed by 'perl Makefile.PL' at the same time that the Makefile is written.
Also increment provides->'Test-Vars'->version
It didn't exist in EU::MM until approx. version 7.12, committed to repository on Apr 29 2016. So if EU::MM is older than that (as it may very well be in older perls whose EU::MMs have not been upgraded), Makefile.PL would gag. It turns out not to have been needed.
65b122b
to
f8d4888
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request prepares for the 0.016 release of Test-Vars. It does so primarily by adapting the configure/build/test/release cycle needed for a CPAN release to the exigencies of the status of Perl 5 in late August/early September 2024.
In monthly development release perl-5.41.3 saw several changes in which long deprecated code was removed from the language. These removals included the elimination of the apostrophe (
'
) from package and variable names and the deprecation of thegiven/when/switch
functionality and the smartmatch (~~
) operator. As a consequence, many CPAN distributions are failing to build or experiencing test failures on CPANtesters. (See, e.g., Perl/perl5#22517 and Perl/perl5#22524.)While Test-Vars was not directly impacted by these changes, its "authoring" system, which might best be described as "
Minilla
wrapping aroundModule-Build-Tiny
," was.Minilla
has an indirect dependency on CPAN librarycommon-sense
, which was broken by the smartmatch removal and which is not likely to be repaired soon. Here's what you get if you try to usecpan
to installMinilla
against blead perl today:What Is To Be Done?
Test-Vars has mostly been failing on CPANtesters for the past two years. If we've repaired its code deficiencies -- which we have in the
master
branch -- then we should by trying to get it to CPANtesters and CPAN as soon as possible. We should work around any problems its build system is experiencing that are outside of our immediate control.To that end, I have replaced
Module::Build::Tiny
in the build system withExtUtils::MakeMaker
. This entailed replacingBuild.PL
withMakefile.PL
and incorporating the guts ofcpanfile
by bringing its data intoMakefile.PL
. (I would have considered usingModule::Build
, but it's no longer shipped with the Perl core distribution and my CPAN-maintenance philosophy calls for elimination of unnecessary dependencies and needless complexities.) I believe that myMakefile.PL
is highly compliant with the documentation for ExtUtils::MakeMaker and CPAN::Meta::Spec. (I've added an author-only test,xt/05_test-meta.t
, to validate the metadata.) I have enough experience with EU::MM andmake
to be able to addmake
targets, so I've addedmake test_author
and aliasmake atest
for ease in further testing. I've made several development releases which are doing well on CPANtesters.Assuming CPANtesters continues to go green, I intend to merge this p.r. into master no later than Saturday, September 14. I will then review and update the documentation in
lib/Test/Vars.pm
, updateChanges
, bump the version number and release to CPAN no later than Thursday, September 19 (in order to be able to take advantage of CPANtesters runs after the monthly Perl dev release scheduled for Sept. 20).