Skip to content

Prepare for 0.016 release #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Sep 14, 2024
Merged

Conversation

jkeenan
Copy link
Contributor

@jkeenan jkeenan commented Sep 11, 2024

This merge request prepares for the 0.016 release of Test-Vars. It does so primarily by adapting the configure/build/test/release cycle needed for a CPAN release to the exigencies of the status of Perl 5 in late August/early September 2024.

In monthly development release perl-5.41.3 saw several changes in which long deprecated code was removed from the language. These removals included the elimination of the apostrophe (') from package and variable names and the deprecation of the given/when/switch functionality and the smartmatch (~~) operator. As a consequence, many CPAN distributions are failing to build or experiencing test failures on CPANtesters. (See, e.g., Perl/perl5#22517 and Perl/perl5#22524.)

While Test-Vars was not directly impacted by these changes, its "authoring" system, which might best be described as "Minilla wrapping around Module-Build-Tiny," was. Minilla has an indirect dependency on CPAN library common-sense, which was broken by the smartmatch removal and which is not likely to be repaired soon. Here's what you get if you try to use cpan to install Minilla against blead perl today:

Failed during this command:
 (optional) MLEHMANN/common-sense-3.75.tar.gz : make NO
 MLEHMANN/Types-Serialiser-1.01.tar.gz        : make_test NO one dependency not OK (common::sense); additionally test harness failed
 (optional) MLEHMANN/JSON-XS-4.03.tar.gz      : make_test NO 2 dependencies missing (Types::Serialiser,common::sense); additionally test harness failed
 KARUPA/TOML-Parser-0.91.tar.gz               : make_test NO one dependency not OK (Types::Serialiser); additionally test harness failed
 KARUPA/TOML-0.97.tar.gz                      : make_test NO one dependency not OK (TOML::Parser); additionally test harness failed
 SKAJI/Minilla-v3.1.25.tar.gz                 : make_test NO one dependency not OK (TOML); additionally test harness failed

What Is To Be Done?

Test-Vars has mostly been failing on CPANtesters for the past two years. If we've repaired its code deficiencies -- which we have in the master branch -- then we should by trying to get it to CPANtesters and CPAN as soon as possible. We should work around any problems its build system is experiencing that are outside of our immediate control.

To that end, I have replaced Module::Build::Tiny in the build system with ExtUtils::MakeMaker. This entailed replacing Build.PL with Makefile.PL and incorporating the guts of cpanfile by bringing its data into Makefile.PL. (I would have considered using Module::Build, but it's no longer shipped with the Perl core distribution and my CPAN-maintenance philosophy calls for elimination of unnecessary dependencies and needless complexities.) I believe that my Makefile.PL is highly compliant with the documentation for ExtUtils::MakeMaker and CPAN::Meta::Spec. (I've added an author-only test, xt/05_test-meta.t, to validate the metadata.) I have enough experience with EU::MM and make to be able to add make targets, so I've added make test_author and alias make atest for ease in further testing. I've made several development releases which are doing well on CPANtesters.

Assuming CPANtesters continues to go green, I intend to merge this p.r. into master no later than Saturday, September 14. I will then review and update the documentation in lib/Test/Vars.pm, update Changes, bump the version number and release to CPAN no later than Thursday, September 19 (in order to be able to take advantage of CPANtesters runs after the monthly Perl dev release scheduled for Sept. 20).

Update MANIFEST; include README.md in MANIFEST.
Log status of hashref returned by WriteMakefile().  (Redirect STDERR to
file on disk.)
Having converted to a Makefile.PL similar to that of Type-Tiny.

Whitespace cleanup.
Attempt to add 'recommends' NOT SUCCEEDING!
Encapsulate code into handle_conflicts().

When envvar PERL_AUTHOR_TESTING is set, test xt/*.t as well.
Calling that sub had no effect on Makefile or MYMETA.json.  Test-Vars is
apparently not complex enough to create conflicts with its revdeps.
Per investigation of Changes for EU::MM 6.57_02.  The more modern
version takes an array ref of authors; the older version only took a
string.
This test will presume that the MYMETA files have been created, which is
performed by 'perl Makefile.PL' at the same time that the Makefile is
written.
Also increment provides->'Test-Vars'->version
It didn't exist in EU::MM until approx. version 7.12, committed to
repository on Apr 29 2016.  So if EU::MM is older than that (as it may
very well be in older perls whose EU::MMs have not been upgraded),
Makefile.PL would gag.  It turns out not to have been needed.
@jkeenan jkeenan merged commit f8d4888 into houseabsolute:master Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant