Sbfds column data changes #251
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... where alone it is used; so that SBFDSColumnData.h does not have implicit dependency on GeneralizedDistance.h
howsohazard
reviewed
Sep 3, 2024
| //try to insert the value if not already there | ||
| auto [inserted_id_entry, inserted] = stringIdValueEntries.emplace(string_id, nullptr); | ||
| if(inserted) | ||
| if(inserted) { |
Contributor
There was a problem hiding this comment.
Style is for newline here
Contributor
There was a problem hiding this comment.
Also, there's logic in InsertFirstIndexIntoStringIdValueEntry to do the right thing, which mimics the logic above (line 658) for numbers.
| static inline double GetMaxDifferenceTerm(const SBFDSColumnData &column, | ||
| GeneralizedDistanceEvaluator::FeatureAttributes &feature_attribs) | ||
| { | ||
| switch(feature_attribs.featureType) |
Contributor
There was a problem hiding this comment.
Why should this be static rather than a method of column data?
| invalidIndices.insert(index); | ||
|
|
||
| if(internedNumberValues.valueInterningEnabled) | ||
| if(internedNumberValues.valueInterningEnabled || internedStringIdValues.valueInterningEnabled) |
Contributor
There was a problem hiding this comment.
This one is important enough that I'm going to include it in another PR going in shortly to make the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results of some microscopic code review of SBFDSColumnData.h.
The one function I haven't yet reviewed to my satisfaction is FindClosestValueIndexForValue