Skip to content

24899: Fixes rare and small string leak #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
howsoRes merged 1 commit into from
Jan 1, 2026
Merged

24899: Fixes rare and small string leak #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Amalgam/interpreter/InterpreterOpcodesBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1531,6 +1531,7 @@ EvaluableNodeReference Interpreter::InterpretNode_ENT_TARGET(EvaluableNode *en,
if(result.IsImmediateValue())
{
double value_number = result.GetValue().GetValueAsNumber();
evaluableNodeManager->FreeNodeIfPossible(result);

if(value_number >= 0)
depth = static_cast<size_t>(value_number);
Expand Down
2 changes: 1 addition & 1 deletion src/Amalgam/interpreter/InterpreterOpcodesListManipulation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ EvaluableNodeReference Interpreter::InterpretNode_ENT_SIZE(EvaluableNode *en, Ev
else if(value.nodeType == ENIVT_CODE && value.nodeValue.code != nullptr)
size = static_cast<double>(value.nodeValue.code->GetNumChildNodes());

evaluableNodeManager->FreeNodeTreeIfPossible(n);
evaluableNodeManager->FreeNodeIfPossible(n);
return AllocReturn(size, immediate_result);
}
else if(n != nullptr)
Expand Down
4 changes: 4 additions & 0 deletions src/Amalgam/interpreter/InterpreterOpcodesLogic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@ EvaluableNodeReference Interpreter::InterpretNode_ENT_AND(EvaluableNode *en, Eva
if(cur.IsImmediateValue())
{
if(!cur.GetValue().GetValueAsBoolean())
{
evaluableNodeManager->FreeNodeIfPossible(cur);
return AllocReturn(false, immediate_result);
}
}
else
{
Expand Down Expand Up @@ -153,6 +156,7 @@ EvaluableNodeReference Interpreter::InterpretNode_ENT_NOT(EvaluableNode *en, Eva
if(cur.IsImmediateValue())
{
bool is_true = cur.GetValue().GetValueAsBoolean();
evaluableNodeManager->FreeNodeIfPossible(cur);
return AllocReturn(!is_true, immediate_result);
}
else
Expand Down