20486: Implements shared deviations #264
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackx111
changed the title
cademack
reviewed
Aug 30, 2024
Member
cademack
left a comment
cademack
left a comment
There was a problem hiding this comment.
Left some comments on some nitpicky stuff and some other more meaningful stuff.
One thing I didn't comment on but I should mention overall - there are a lot of (accum) opcodes within loops here in these changes which is a pretty doomed pattern to use within Amalgam. We should definitely try to iron those out into something more functional if possible.
…howso-engine into 20486-shared-deviations
jackx111
force-pushed
the
20486-shared-deviations
branch
from
8f60254 to
2e3b099
Compare
cademack
reviewed
Nov 13, 2024
| )) | ||
|
|
||
| (declare (assoc | ||
| smallest_count_above_statistical_significance (first (sort class_counts_above_stat_significance)) |
Member
There was a problem hiding this comment.
surely this can just be a (min)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.