Skip to content

22135: Fixes datatype inconsistencies to match new Amalgam version. #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
howsohazard merged 3 commits into from
Nov 10, 2024
Merged

22135: Fixes datatype inconsistencies to match new Amalgam version. #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44702da
22135: Fixes datatype inconsistencies
howsoRes Nov 8, 2024
92e14f0
version bump
howsoRes Nov 8, 2024
337d808
Merge branch 'main' into 22135-datatype-consistency-fixes
howsohazard Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions howso/upgrade.amlg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,9 +420,9 @@
point 0
)
(assign (assoc
major (first file_versions)
minor (get file_versions 1)
point (last file_versions)
major (+ (first file_versions))
minor (+ (get file_versions 1))
point (+ (last file_versions))
))

;keep files with newer major version. if major is same, consider minor version, etc.
Expand Down
4 changes: 2 additions & 2 deletions unit_tests/ut_h_string_ordinals.amlg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@

(print "Proper nominals data_type is preserved: ")
;bool is converted to a sting because it wasn't specified as data_type : boolean
(call assert_same (assoc obs result exp (list 3 "false" (false))))
(call assert_same (assoc obs result exp (list 3 "(false)" (false))))


(assign (assoc
Expand All @@ -99,7 +99,7 @@
(call_entity "howso" "single_react" (assoc
context_features (list "bool" "bool_nom")
;bool will be treated as a string
context_values (list "true" (false))
context_values (list "(true)" (false))
action_features (list "value" )
))
(list 1 "payload" "action_values")
Expand Down
2 changes: 1 addition & 1 deletion version.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"version": "0.0.0",
"dependencies": {
"amalgam": "56.0.0"
"amalgam": "57.0.0"
}
}