-
Notifications
You must be signed in to change notification settings - Fork 2
13693: Adds "boundary_values" as a detail to #react, MINOR #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howsoRes
reviewed
Nov 12, 2024
howsoRes
reviewed
Nov 12, 2024
howsoRes
reviewed
Nov 12, 2024
howsoRes
reviewed
Nov 12, 2024
howsoRes
reviewed
Nov 12, 2024
howsoRes
reviewed
Nov 20, 2024
howsoRes
reviewed
Nov 20, 2024
howsoRes
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new detail to
#react: "boundary_values_context_features". This detail allows users to ask questions about how much context values would have to change to observe differences in the resulting predictions.The API changes are as follows:
#react(and#single_react) now accept 2 additional indices within thedetails(assoc) parameter.boundary_values_action_outcome, which accepts a map of conditions for each action feature. This allows users to specify a condition that indicates the boundary in which they are interested in. For example, a user could specify{"feat1" [5 15]}which would then find the boundary values that would cause the prediction of "feat1" to be within the range of 5 to 15. (This condition formatting matches that of the standardConditionschema)When
boundary_values_action_outcomeis specified, the boundary is considered "well defined", and the algorithm will attempt to find the closest values to the given context values that cross the boundary. When it is unspecified, there are two possibilities. If all action features are nominal, then the boundary is still considered "well defined" and any change in the action values will indicate a crossed boundary and the algorithm still searches for the closest values that cross this boundary. In the case thatboundary_values_action_outcomeis unspecified and there are non-nominal action features, then the algorithm will attempt to find the closest local maxima of the gradient in the change of action values with respect to the change in context values.With the current implementation, boundary values can be computed for continuous, nominal, and ordinal (numeric and string) features. It is not supported for edit-distance features (JSON, YAML, Amalgam).