Skip to content

22311: Fixes an issue where undescribed parameters list their type annotation as descriptions #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cademack merged 3 commits into from
Nov 25, 2024
Merged

22311: Fixes an issue where undescribed parameters list their type annotation as descriptions #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3559760
Fixes an issue where undescribed parameters list their type definitio…
cademack Nov 25, 2024
73f7518
more specific pattern
cademack Nov 25, 2024
e50f1b5
fix the order
cademack Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion howso.amlg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,7 @@
;replace the typing assoc with an empty string, only get description
(substr
(first (current_value 1))
"\\{.+\\}\\r\\n"
"^\\{.+\\}\\r?\\n?"
(null)
""
)
Expand Down
2 changes: 1 addition & 1 deletion howso/hyperparameters.amlg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,8 +779,8 @@
;the factor by which to increase the analyze threshold every time the model grows to the current threshold size
; default of two orders of magnitude using the universal scaling factor e
analyze_growth_factor 7.389056
;parameter for analyze
;{type "list" values "string"}
;parameter for analyze
context_features (null)
;{type "list" values "string"}
action_features (null)
Expand Down
2 changes: 1 addition & 1 deletion howso/react.amlg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
;full list of features to output values for the case
action_features (list)
;{type "list" values {type "list"}}
;;values of action features. If specified will bypass react and only do the explanation if details is set.
;values of action features. If specified will bypass react and only do the explanation if details is set.
;if specified must be either length of 1 or num_reacts. One list us used per individual reaction
action_values (null)
;{type "list" values "string"}
Expand Down