Skip to content

24795: Adds multithreading for computing continuous stats and other misc performance improvements #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
howsoRes merged 6 commits into from
Dec 4, 2025
Merged

24795: Adds multithreading for computing continuous stats and other misc performance improvements #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
09ba5cb
24795: Added multithreading for computing continuous stats
howsoRes Dec 3, 2025
eea840d
fix incorrect offset
howsoRes Dec 3, 2025
308d0dd
update test
howsoRes Dec 4, 2025
90a99ee
test cleanup and code simplification
howsoRes Dec 4, 2025
4a7f7c8
Merge branch 'main' into 24795-mt-continuous-stats
howsoRes Dec 4, 2025
fc14c78
rearrange stat compute to maximize performance and prevent race condi…
howsoRes Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions howso/analysis_weights.amlg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,10 +358,8 @@
)
)

;else normal continuous feature, compute max gap
(compute_on_contained_entities
(query_max_difference (current_index 1) (get !cyclicFeaturesMap (current_index 1)) )
)
;else normal continuous feature, pull cached max gap
(get !cachedFeatureMaxGapMap (current_index 1))
)
min_gap
(if (contains_index !editDistanceFeatureTypesMap (current_index 1))
Expand All @@ -371,8 +369,9 @@
(query_min_difference (current_index 1) (get !cyclicFeaturesMap (current_index 1)) )
)
)
num_buckets (size (remove (compute_on_contained_entities (query_value_masses (current_index 1) )) [(null)]))
num_values (size (compute_on_contained_entities (query_not_equals (current_index 1) (null))))
;pull from cached marginal stats
num_buckets (get !featureMarginalStatsMap [weight_feature (current_index 2) "uniques"])
num_values (get !featureMarginalStatsMap [weight_feature (current_index 2) "count"])
)

;infinity means there was no gap, and nan means all values are null and can't compute gap
Expand Down
Loading