feat: [WIP] Find neighbourhood in MPI #295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbstndb
changed the title
|
At this point, the neighbourhood construction is working fine. |
|
At this point, I have an issue on Choleski with 32 ranks on advection-2d --min-level 4 or lower (the modified balanced case). This is because one cell is coarser than its subdomain. I don't think it is related to this PR anyway ... |
- Previously, in multirank MPI, m_cells was empty due to a bad n_cells per subdomains computation - Then I add a specific partitioning for 1D MPI : - We compute the number of cells in the original mesh - Each subdomain get a part of the nb_cells
- Not working FOR NOW - We need to reduce the neighbourhood size. Then, we need to construct it based on each subdomain - We construct a first extended nogihbourhood to get all the potential intersection - And then we intersect each subdomain - **BUT**, we need a kind of "expand" feature. - This expand allows us to detect neighbourhood - Nevertheless, maybe a expand of one is not enough.
- Previsouly, we use per-level ghost-and-cells - It is not the right method, we need to use subdomain mehs - Then we use translation to operate as an "expand"
- This is not really beautiful, it needs more work - Todo : - arbitrary nD - create a new special function
- Now we have a dedicated function to find neighbourhood
- We can use constexrp here.
sbstndb
force-pushed
the
better_neighbour_2
branch
from
b7951aa to
e0c1237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP do not merge, it is for CI testing.