Skip to content

Pflarr/fix autoexit #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Pflarr/fix autoexit #882

wants to merge 3 commits into from

Conversation

Paul-Ferrell
Copy link
Collaborator

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

@Paul-Ferrell
Copy link
Collaborator Author

Paul-Ferrell commented Jul 11, 2025

This addresses an issue I found when doing PE testing this morning.
If you set autoexit to false, there's now a echo statement between the last command and the script end that will cause the test to pass even if it should have failed.
The other issues was that the err bash function should do an exit 1 rather than a return 1, so that script failure is forced even when autoexit is false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants