-
Notifications
You must be signed in to change notification settings - Fork 40
update vsc-Rproject documentation #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WouterVanAssche
wants to merge
2
commits into
master
Choose a base branch
from
rstudio_documentation_update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is indeed better, but I would still like to see this higher up the page because it describes an important part of how vsc-Rproject works. So I'd suggest to for example put it in a new subsection in between
Activating a projectandDeactivating a project(perhaps calling itAdding R packages to the project?).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I like this idea. That section is explaining one by one the different subcommands
create,activate,deactivate, andconfigure. Installing packages in an RStudio Project is not something specific to vsc-Rproject. vsc-Rproject just facilitates the setup of your project directory and the package libary in a correct way.The moment the project is created the job of vsc-Rproject is pretty much done. All it then needs to do is make sure the correct modules are in place whenever you want to use it.
Installing packages in the project's package library, whether via command line R or RStudio does not dependent on vsc-Rproject anymore. That is why I have these two separate sections ("vsc-Rproject and RStudio Server" and "Using the Environment and installing software") at the end of the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The argument that this does not correspond to a specific vsc-Rproject subcommand does not hold. What counts is what happens from a user perspective. The main and perhaps only reason they are using vsc-Rproject is to install their own R packages, and so that step is as essential as the vsc-Rproject subcommands themselves. If you check our pages on Python, Conda, and the like, will see the same create-environment/activate-environment/install-stuff-in-environment/deactivate-environment structure ;)