Remove an association (HPC-7692) #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdweird
reviewed
Apr 30, 2019
| slurm_acct_users = set([user for (user, acct) in cluster_users_acct if acct == vo_id]) | ||
| slurm_acct_users = set([user for (user, def_acct, _) in cluster_users_acct if def_acct == vo_id]) | ||
|
|
||
| # these are the users for which an earlier delete failed because they still had live job in their (at that |
There was a problem hiding this comment.
says who? these users are part of this set, but there might be others to, no?
There was a problem hiding this comment.
No, we grab them all. AFAICT.
There was a problem hiding this comment.
Maybe I misunderstood. What others and where?
There was a problem hiding this comment.
- By default, we only have one account per user.
- When a user switches VO, he will be added to the new VO and the default account will be set to the new VO. He might not be removed from the old.
- When we look through the associations, I believe we find all those that need to be removed. If they fail to be removed due to running jobs, they will be picked up again the next run. New jobs should be submitted under the default account, thus the jobs under the new association will eventually be gone.
What am I missing?
|
@itkovian is this PR still needed? could you update it to 2020? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.