Change the main to rely on the Sync class (HPC-7469) #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpoely86
reviewed
Nov 26, 2019
| if opts.options.user: | ||
| changed_accounts = client.account.institute[institute].modified[last_timestamp].get()[1] | ||
| if self.options.user: | ||
| changed_accounts, _ = self.apc.get_accounts() # we ignore inactive accounts |
There was a problem hiding this comment.
no institute nor timestamp passed?
There was a problem hiding this comment.
No, this taken care of by the Sync class.
There was a problem hiding this comment.
should be self.get_accounts, the timestamp is processed in sync class, not APclient
There was a problem hiding this comment.
and found no clue where the site/institute should have been taken care of
itkovian
force-pushed
the
syncify-user-sync
branch
from
44f5438 to
47e2ce3
Compare
|
@itkovian conflicts |
kwaegema
reviewed
Jan 14, 2021
| if users_fail or quota_fail or vos_fail: | ||
| return users_fail + quota_fail + vos_fail | ||
| else: | ||
| return False |
There was a problem hiding this comment.
nothing done with stats? set self.thresholds = stats ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.