test(app): fix further tests

hpi-dhc · Nov 29, 2024 · 828ab91 · 828ab91
1 parent 943f2d0
commit 828ab91
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 13 deletions.
diff --git a/app/integration_test/drugs_test.dart b/app/integration_test/drugs_test.dart
@@ -106,14 +106,20 @@ void main() {
     ) as Switch;
     expect(activitySelection.onChanged, isLoading ? isNull : isNotNull);
     expect(activitySelection.value, expectDrugToBeActive ? isTrue : isFalse);
+    await tester.tap(find.byKey(Key('drug-information-expansion-tile')));
+    await tester.pumpAndSettle();
     // Drug details
     expect(
       find.textContaining(
-        drug.annotations.drugclass
+        drug.annotations.drugclass,
+        skipOffstage: false,
       ),
       findsOneWidget,
     );
-    expect(find.text(drug.annotations.indication), findsOneWidget);
+    expect(
+      find.text(drug.annotations.indication, skipOffstage: false),
+      findsOneWidget,
+    );
     // Guideline details
     final card = tester.firstWidget(
       find.byKey(
@@ -147,7 +153,7 @@ void main() {
         findsOneWidget,
       );
       expect(
-        find.text(context.l10n.drugs_page_no_guidelines_text),
+        find.textContaining(context.l10n.drugs_page_no_guidelines_text),
         findsOneWidget,
       );
       if (drug.guidelines.isNotEmpty) {
@@ -170,7 +176,7 @@ void main() {
         findsOneWidget,
       );
       expect(
-        find.text(relevantGuideline.annotations.implication),
+        find.textContaining(relevantGuideline.annotations.implication),
         findsOneWidget,
       );
       expect(

diff --git a/app/integration_test/report_test.dart b/app/integration_test/report_test.dart
@@ -31,7 +31,7 @@ void main() {
           home: Scaffold(
             body: Builder(
               builder: (context) {
-                return ReportPage();
+                return ReportPage(onlyShowWholeReport: true);
               },
             ),
           ),

diff --git a/app/lib/drug/widgets/annotation_cards/drug.dart b/app/lib/drug/widgets/annotation_cards/drug.dart
@@ -50,6 +50,7 @@ class DrugAnnotationCards extends StatelessWidget {
         ),
         SizedBox(height: PharMeTheme.smallSpace),
         PrettyExpansionTile(
+          key: Key('drug-information-expansion-tile'),
           title: SubHeader(context.l10n.drugs_page_header_drug),
           visualDensity: VisualDensity.compact,
           titlePadding: EdgeInsets.zero,

diff --git a/app/lib/drug/widgets/annotation_cards/guideline.dart b/app/lib/drug/widgets/annotation_cards/guideline.dart
@@ -77,7 +77,7 @@ class GuidelineAnnotationCard extends StatelessWidget {
           Text.rich(
             TextSpan(
               children: [
-                TextSpan(
+                if (implicationText != null) TextSpan(
                   text: context.l10n.drugs_page_implication_description,
                 ),
                 TextSpan(text: '\n'),

diff --git a/app/lib/report/pages/report.dart b/app/lib/report/pages/report.dart
@@ -26,6 +26,11 @@ class ListOption {
 
 @RoutePage()
 class ReportPage extends HookWidget {
+  const ReportPage({@visibleForTesting this.onlyShowWholeReport = false});
+
+  // Currently for testing but might use in the future
+  final bool onlyShowWholeReport;
+
   @override
   Widget build(BuildContext context) {
     final currentListOption = useState(0);
@@ -115,13 +120,15 @@ class ReportPage extends HookWidget {
     ActiveDrugs activeDrugs,
     ValueNotifier<int> currentListOptionIndex,
   ) {
-    final listOptions = [
-      ListOption(
-        label: context.l10n.report_current_medications,
-        drugSubset: activeDrugs.names,
-      ),
-      ListOption(label: context.l10n.report_all_medications),
-    ];
+    final listOptions = onlyShowWholeReport
+      ? [ListOption(label: context.l10n.report_all_medications)]
+      : [
+        ListOption(
+          label: context.l10n.report_current_medications,
+          drugSubset: activeDrugs.names,
+        ),
+        ListOption(label: context.l10n.report_all_medications),
+      ];
     final currentListOption = listOptions[currentListOptionIndex.value];
     final geneCards = _buildGeneCards(
       drugsToFilterBy: currentListOption.drugSubset,