Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type checks #562

Merged
merged 4 commits into from
Jan 23, 2024
Merged

fix: type checks #562

merged 4 commits into from
Jan 23, 2024

Conversation

hig-dev
Copy link
Contributor

@hig-dev hig-dev commented Jan 17, 2024

Using runtimeType for type checks ist not recommended and I experienced a bug related to that.
This PR uses the pattern matching feature from Dart 3.0.

More info on type matching is here: dart-lang/language#2911 (comment)

@github-actions github-actions bot added dependencies Pull requests that update a dependency file app core designer_v2 labels Jan 17, 2024
Copy link

github-actions bot commented Jan 17, 2024

Visit the preview URL for this PR (updated for commit 92629cb):

(expires Wed, 24 Jan 2024 13:20:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2149dad49ed83535217e50d5c18c0c8c90da629b

@hig-dev hig-dev requested review from johannesvedder and removed request for johannesvedder January 17, 2024 10:10
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 17, 2024
Copy link
Contributor

@johannesvedder johannesvedder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@hig-dev hig-dev merged commit 10ac2fb into dev Jan 23, 2024
3 checks passed
@hig-dev hig-dev deleted the fix/type-checking branch January 23, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app core dependencies Pull requests that update a dependency file designer_v2 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants