Fix local models and render terminal images natively - #7
Merged
Conversation
hrhrng
marked this pull request as ready for review
August 3, 2026 16:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dconfirmation/forgetremove persisted reading progress, speech checkpoints, and the bare-launch resume target as well as the library entryWhy
The model installer could briefly report
downloadingand then return tonot downloadedbecause the generated Hugging Face call used the wrong argument. Separately, illustrations were always downsampled into Unicode half blocks even when the terminal supported exact pixel graphics./forgetalso left the book's content-keyed state behind, so reimporting the same file resumed the old session and suppressed the fresh-book cover.Validation
cargo fmt --checkcargo test --locked --test image --test illustration(18 passed)cargo test --locked --test render(27 passed)cargo test --locked --lib(244 passed)cargo test --locked --test library(11 passed)cargo test --locked(all completed batches passed; one timing-sensitive render test timed out once and passed both isolated and full-suite reruns)cargo build --release --locked