Replaced i and b tags with em and strong as per HTML 5 Standard#9
Open
noopur-tiwari wants to merge 1 commit into
Open
Replaced i and b tags with em and strong as per HTML 5 Standard#9noopur-tiwari wants to merge 1 commit into
noopur-tiwari wants to merge 1 commit into
Conversation
Owner
|
Hey noopur-tiwari, the strong tag has no issue but the things where you changed the i tag with em that is not correct |
|
Hi I am new to open source community.How do i contribute to your work. i have forked and made changes replacinng i tags with span tags and pushed it. I want to know more. could you please help me |
Owner
sure you can first resolve all teh conflicts for this PR and push it. i will review & merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apart from replacing i and b tags with em and strong tags respectively, I have also indented the code in Visual Studio Code, thus it is showing almost the entire code as modified which is not the case.