Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove more __MINGW32__ ifdefs #19889

Merged
merged 3 commits into from
Jan 19, 2025
Merged

remove more __MINGW32__ ifdefs #19889

merged 3 commits into from
Jan 19, 2025

Conversation

oltolm
Copy link
Contributor

@oltolm oltolm commented Jan 19, 2025

This PR removes more __MINGW32__ ifdefs and fixes some CMake warnings. CMake shows this warning:

[cmake] CMake Deprecation Warning at CMakeLists.txt:2 (cmake_minimum_required):
[cmake]   Compatibility with CMake < 3.10 will be removed from a future version of
[cmake]   CMake.
[cmake] 
[cmake]   Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
[cmake]   to tell CMake that the project requires at least <min> but has been updated
[cmake]   to work with policies introduced by <max> or earlier.

Maybe we should just remove cmake_minimum_required from all CMakeLists.txt but the top one.

@hrydgard hrydgard added this to the v1.19.0 milestone Jan 19, 2025
@hrydgard
Copy link
Owner

hrydgard commented Jan 19, 2025

Yeah, probably sensible to clean out those minimum_required.

Great cleanups!

@hrydgard hrydgard merged commit e2c9376 into hrydgard:master Jan 19, 2025
19 checks passed
@oltolm oltolm deleted the mingw32 branch January 19, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants