chore: cleanup debouncing and reduce debounce time to 1s

[hrzlgnm]

Summary by CodeRabbit

• Refactor

  • Optimized application responsiveness with faster debouncing (reduced from 2 seconds to 1 second).
  • Improved resource cleanup efficiency through more frequent cleanup operations.

• Tests

  • Adjusted test expectations for metric tracking changes.

[hrzlgnm]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR tightens debounce and cleanup timing in the TUI application, adjusting constants to fire more aggressively (2s→1s debounce, 500ms→250ms cleanup), simplifies the expired pending removal logic path by removing a conditional branch, and eliminates the flapping_prevented_ui_updates metric from being recorded when a removal is canceled.

Changes

Cohort / File(s)	Summary
Timing & Metrics Adjustments src/tui_app.rs	Reduced DEBOUNCE_DURATION_MICROS (2s → 1s) and CLEANUP_INTERVAL_MS (500ms → 250ms); removed conditional branch in expired pending removal logic to always call mark_service_offline; eliminated flapping_prevented_ui_updates metric recording on cancellation; updated test expectations accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: resolve race condition in ServiceResolved handling #163: Adjusts pending-removal and cleanup behavior with modified debounce/cleanup scheduling and service lifecycle logic in the same file.
• refactor: rename remove_service to mark_service_offline and remove unused parameter #82: Refactored remove_service to mark_service_offline, which is now the consolidated removal path used after this PR's simplification.
• feat: implement 2-second service debouncing for flapping services #162: Introduced the original debounce implementation that this PR now tunes with more aggressive timing constants.

Poem

⚡ Debounce shrinks from two down to one,
Cleanup ticks faster—let's get it done!
Flapping metrics fade into the night,
Expiring removals? Always mark offline, that's right.
Tighter, leaner, meaner UI state,
Oh boy, performance just leveled up—no time to wait! 🚀

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main changes: debounce logic cleanup and reduction of debounce time from 2s to 1s, which aligns with the primary focus of the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/cleanup-debouce

---

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}