Realnvp/Nice odd dim#74
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Coupling layer flows have been failing for odd numbers of dimensions. In the coupling models we define a
pass_size = in_size // 2wherein_sizeis the number of dimensions and anet_in_size = in_size - pass_size. Then in each layer we split the data in toxa = x[:, :pass_size]andxb = x[:, pass_size:]soxbhas shape(len(samples), net_in_size)andxahas shape(len(samples), pass_size).xbis then passed through a neural network that outputs values (s and m in a realnvp) with shapes given bynet_in_size. Then when you operate with these outputs onxayou get shape mismatches e.g. in a realnvp you doxa = xa * jnp.exp(s) + m. This works fine for even dimensions becausepass_size = net_in_size.Checklist:
python -m pytest)