Skip to content

Update Node versions used on GitHub Actions - #1283

Merged
coliff merged 1 commit into
masterfrom
1202-update-node-versions-used-on-github-actions
Mar 18, 2023
Merged

coliff merged 1 commit into
masterfrom
1202-update-node-versions-used-on-github-actions

Conversation

@coliff

@coliff coliff commented Feb 10, 2023

Copy link
Copy Markdown
Member

@coliff
coliff requested a review from thedaviddias as a code owner February 10, 2023 12:11
@coliff coliff linked an issue Feb 10, 2023 that may be closed by this pull request
@coliff
coliff requested a review from nschonni February 10, 2023 12:12
@github-actions github-actions Bot added automation Changes done to the .github folder dependencies Pull requests that update a dependency file labels Feb 10, 2023
@coliff coliff added github_actions and removed dependencies Pull requests that update a dependency file automation Changes done to the .github folder labels Feb 10, 2023
@codecov

codecov Bot commented Feb 10, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1283 (5d0295e) into master (02edc57) will not change coverage.
The diff coverage is n/a.

❗ Current head 5d0295e differs from pull request most recent head 1487458. Consider uploading reports for the commit 1487458 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1283   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files           2        2           
  Lines        1627     1627           
  Branches      332      332           
=======================================
  Hits         1612     1612           
  Misses         15       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02edc57...1487458. Read the comment docs.

@github-actions github-actions Bot added automation Changes done to the .github folder dependencies Pull requests that update a dependency file labels Feb 10, 2023
@coliff
coliff enabled auto-merge (squash) February 13, 2023 00:03
@coliff

coliff commented Feb 13, 2023

Copy link
Copy Markdown
Member Author

is this good to merge @nschonni @thedaviddias ?

@nschonni

Copy link
Copy Markdown
Contributor

Same comment as #1202 (comment)
I think it makes sense, but dropping supported versions is usually a semver major change, so it needs a version bump. It would probably be the time to include the other breaking change in #728

@coliff
coliff force-pushed the 1202-update-node-versions-used-on-github-actions branch from 461778f to 6128b2d Compare February 14, 2023 13:24
@coliff
coliff force-pushed the 1202-update-node-versions-used-on-github-actions branch from 6128b2d to 1487458 Compare February 14, 2023 13:25
@coliff

coliff commented Feb 14, 2023

Copy link
Copy Markdown
Member Author

Same comment as #1202 (comment) I think it makes sense, but dropping supported versions is usually a semver major change, so it needs a version bump. It would probably be the time to include the other breaking change in #728

Ok - thanks for feedback and suggestion. Updated now and all tests are passing! 👍

@coliff
coliff requested review from nschonni and removed request for nschonni March 18, 2023 01:52
@coliff
coliff merged commit 23672f5 into master Mar 18, 2023
@coliff
coliff deleted the 1202-update-node-versions-used-on-github-actions branch March 18, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation Changes done to the .github folder dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Node versions used on GitHub Actions

2 participants