Skip to content

Conversation

@edlu77
Copy link
Contributor

@edlu77 edlu77 commented Oct 31, 2025

@edlu77 edlu77 requested a review from axdanbol October 31, 2025 21:03
@edlu77 edlu77 self-assigned this Oct 31, 2025
@nx-cloud
Copy link

nx-cloud bot commented Oct 31, 2025

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit 1e4c985

Command Status Duration Result
nx affected --targets=lint,test,compodoc --conf... ❌ Failed 2m 51s View ↗
nx affected --target=build,build-webcomponent,b... ✅ Succeeded 3m 19s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-03 19:27:13 UTC

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

🚀 Preview Deploy Report

✅ Successfully deployed preview here

@axdanbol axdanbol marked this pull request as ready for review November 11, 2025 19:27
Copy link
Contributor

@axdanbol axdanbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename entire thing to filter-menu. Also after talking to Libby we decided that the kg-explorer version is separate from this component so you don't have to implement that here!

@bherr2 bherr2 changed the title Tune menu shell Filter menu shell Nov 17, 2025
@edlu77 edlu77 requested a review from LibbyUX November 17, 2025 23:33
Copy link
Contributor

@LibbyUX LibbyUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edlu77 thank you so much for making this crucial component happen! Just a few questions and notes for this review:

  1. Can we please use label medium (14px metropolis medium/500 weight) for the button toggle buttons and the filter container buttons?
  2. I see I didn't add a max width to this, but maybe we just want this to be a fixed width. Is it possible to do fixed width of 320px?
  3. Is it possible to link to the HRA Components page in Storybook?

Thanks for rocking this out. Let me know if you need anything to get this across the finish line! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants