-
Notifications
You must be signed in to change notification settings - Fork 5
Filter menu shell #1867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Filter menu shell #1867
Conversation
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=lint,test,compodoc --conf... |
❌ Failed | 2m 51s | View ↗ |
nx affected --target=build,build-webcomponent,b... |
✅ Succeeded | 3m 19s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-12-03 19:27:13 UTC
🚀 Preview Deploy Report✅ Successfully deployed preview here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename entire thing to filter-menu. Also after talking to Libby we decided that the kg-explorer version is separate from this component so you don't have to implement that here!
…into tune-menu-shell
…into tune-menu-shell
LibbyUX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @edlu77 thank you so much for making this crucial component happen! Just a few questions and notes for this review:
- Can we please use label medium (14px metropolis medium/500 weight) for the button toggle buttons and the filter container buttons?
- I see I didn't add a max width to this, but maybe we just want this to be a fixed width. Is it possible to do fixed width of 320px?
- Is it possible to link to the HRA Components page in Storybook?
Thanks for rocking this out. Let me know if you need anything to get this across the finish line! ✨
…into tune-menu-shell

Need this to be completed: