feat: Add no_ssh and slurm multinode launcher options for deepspeed #3329
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsmallbone
force-pushed
the
deepspeed_no_ssh
branch
2 times, most recently
from
bbd4d7f to
5f76bba
Compare
hsmallbone
force-pushed
the
deepspeed_no_ssh
branch
from
5f76bba to
44721ac
Compare
XuehaiPan
reviewed
Jan 8, 2025
muellerzr
reviewed
Jan 8, 2025
…nsure that deepspeed 0.14.5 version is used for nossh
|
I couldn't actually see any documentation referring specifically to this parameter, so I have added a small section to the DeepSpeed docs. I also took the opportunity to add slurm to the list of constants for multinode launchers, which should work as it uses the same parameters (https://github.com/microsoft/DeepSpeed/blob/master/deepspeed/launcher/multinode_runner.py#L338). |
hsmallbone
changed the title
muellerzr
approved these changes
Jan 9, 2025
|
As far as I can see that is a GitHub actions error not an issue with my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows the use of the no_ssh option in DeepSpeed (https://www.deepspeed.ai/getting-started/#launching-without-passwordless-ssh) which is helpful in restricted network environments / HPC clusters to use srun/mpirun instead of setting up passwordless SSH.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@muellerzr