chore: update markdown formatting inside <Tip> #3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markdown formatting isn't working well inside the `<Tip>` element.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
it doesn't seem to work well either with your change https://moon-ci-docs.huggingface.co/docs/dataset-viewer/pr_3126/en/postgresql Maybe simply remove the and keep it as plain text |
|
That's a shame, I'll make that change now |
Markdown formatting is not working as expected inside of the `<Tip>` component
|
I've just thought that we could've just replaced the markdown elements with HTML and the formatting would be correct inside of the Tip component. Would you like me to submit that change? |
|
I haven't tried that, not sure if it works. No strong opinion though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markdown formatting isn't working well inside the
<Tip>element.This might be affecting other pages as well, but this is the one I came across.