Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] make tests device-agnostic (part 4) #10508

Merged
merged 48 commits into from
Mar 4, 2025
Merged

Conversation

faaany
Copy link
Contributor

@faaany faaany commented Jan 9, 2025

What does this PR do?

Follow up of PR #10437

@faaany faaany marked this pull request as ready for review January 22, 2025 02:01
@faaany
Copy link
Contributor Author

faaany commented Jan 22, 2025

@hlky

@faaany
Copy link
Contributor Author

faaany commented Feb 5, 2025

Hi @sayakpaul @hlky @DN6 , could we proceed with this PR? Thx a lot!

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very nuch. Just a single comment for clarification.

@hlky
Copy link
Member

hlky commented Feb 27, 2025

@bot /style

@hlky
Copy link
Member

hlky commented Feb 27, 2025

@bot /style

Copy link
Member

@hlky hlky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @faaany

@hlky
Copy link
Member

hlky commented Feb 27, 2025

@faaany If you go to the Files tab you can add multiple suggestions to a batch and commit them at once, this avoids many notifications for maintainers.

@faaany
Copy link
Contributor Author

faaany commented Feb 27, 2025

@faaany If you go to the Files tab you can add multiple suggestions to a batch and commit them at once, this avoids many notifications for maintainers.

Thanks so much for the correction! Code Updated.

@hlky
Copy link
Member

hlky commented Mar 4, 2025

Failing tests are unrelated.

@hlky hlky merged commit 7855ac5 into huggingface:main Mar 4, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants