Skip to content

Fixing missing provider options argument #11397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 28, 2025
Merged

Fixing missing provider options argument #11397

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
651630b
Fixing missing provider options argument
Apr 23, 2025
1e1e3e4
Merge branch 'main' into fixing_provider_options
sayakpaul Apr 23, 2025
37c5e65
Adding if else for provider options
urpetkov-amd Apr 23, 2025
0596a35
Merge branch 'main' into fixing_provider_options
urpetkov-amd Apr 28, 2025
1887138
Apply suggestions from code review
sayakpaul Apr 28, 2025
73f0c6f
Merge branch 'main' into fixing_provider_options
sayakpaul Apr 28, 2025
1009590
Apply style fixes
github-actions[bot] Apr 28, 2025
f97dca7
Update src/diffusers/pipelines/onnx_utils.py
urpetkov-amd Apr 28, 2025
2b7cc65
Update src/diffusers/pipelines/onnx_utils.py
urpetkov-amd Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/diffusers/pipelines/onnx_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def load_model(path: Union[str, Path], provider=None, sess_options=None, provide
provider = "CPUExecutionProvider"

return ort.InferenceSession(
path, providers=[provider], sess_options=sess_options, provider_options=provider_options
path, providers=[provider], sess_options=sess_options, provider_options=[provider_options]
Copy link
Preview

Copilot AI Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapping provider_options in a list may result in [None] if provider_options is not provided. Consider defaulting to an empty list or checking for a non-null value before wrapping.

Copilot uses AI. Check for mistakes.

)

def _save_pretrained(self, save_directory: Union[str, Path], file_name: Optional[str] = None, **kwargs):
Expand Down Expand Up @@ -174,7 +174,7 @@ def _from_pretrained(
# load model from local directory
if os.path.isdir(model_id):
model = OnnxRuntimeModel.load_model(
Path(model_id, model_file_name).as_posix(), provider=provider, sess_options=sess_options
Path(model_id, model_file_name).as_posix(), provider=provider, sess_options=sess_options, provider_options=kwargs.get("provider_options")
)
kwargs["model_save_dir"] = Path(model_id)
# load model from hub
Expand All @@ -190,7 +190,7 @@ def _from_pretrained(
)
kwargs["model_save_dir"] = Path(model_cache_path).parent
kwargs["latest_model_name"] = Path(model_cache_path).name
model = OnnxRuntimeModel.load_model(model_cache_path, provider=provider, sess_options=sess_options)
model = OnnxRuntimeModel.load_model(model_cache_path, provider=provider, sess_options=sess_options, provider_options=kwargs.get("provider_options"))
return cls(model=model, **kwargs)

@classmethod
Expand Down
Loading