Skip to content

[train_dreambooth_lora.py] Set LANCZOS as default interpolation mode for resizing #11421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2025

Conversation

merterbak
Copy link
Contributor

What does this PR do?

It makes LANCZOS the default interpolation mode for the image resizing. It fixes #11390.

Before submitting

Who can review?

@asomoza

@merterbak merterbak changed the title Set LANCZOS as default interpolation mode for resizing [train_dreambooth_lora.py] [train_dreambooth_lora.py] Set LANCZOS as default interpolation mode for resizing Apr 25, 2025
@merterbak merterbak changed the title [train_dreambooth_lora.py] Set LANCZOS as default interpolation mode for resizing [train_dreambooth_lora.py] Set LANCZOS as default interpolation mode for resizing Apr 25, 2025
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@asomoza
Copy link
Member

asomoza commented Apr 26, 2025

thanks @merterbak, for contributing in diffusers you have to format the code, can you run these two commands on the console:

make style
make quality

If for some reason you can't run them, I can run a bot that does this for you, but it's always better to run it yourself, specially for larger contributions of code with multiple reviews.

@merterbak
Copy link
Contributor Author

Ok, thank you for valuable advice.

Copy link
Member

@asomoza asomoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@asomoza
Copy link
Member

asomoza commented Apr 26, 2025

failing test are not related to this PR

@asomoza asomoza merged commit bd96a08 into huggingface:main Apr 26, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better image interpolation in training scripts follow up
3 participants