Skip to content

Add missing base64 decoding for audio-classification #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025
Merged

Conversation

alvarobartt
Copy link
Member

@alvarobartt alvarobartt commented Jul 17, 2025

Description

This PR fixes the base64 handling for audio-classification too, upon merging #116, since audio-classification was missing.

cc @ErikKaum @beurkinger

@alvarobartt alvarobartt requested a review from ErikKaum July 17, 2025 09:51
Copy link

@beurkinger beurkinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank uuuuu !!!

Copy link
Member

@ErikKaum ErikKaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending green ci, thank you 👍

@alvarobartt
Copy link
Member Author

I just realized that there might be an alternative simpler solution as per #116, so either this PR or that PR could be merged to fix the issue 🤗

@ErikKaum
Copy link
Member

Yes @alvarobartt let's go with that one instead 👍

@alvarobartt alvarobartt changed the title Fix base64 audio handling for automatic-speech-recognition Add missing base64 decoding for audio-classification Jul 17, 2025
@ErikKaum ErikKaum merged commit 9c5e3e5 into main Jul 17, 2025
6 checks passed
@ErikKaum ErikKaum deleted the fix-audio-base64 branch July 17, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants